Skip to content

[HDRP] Fix volume component nullref #3644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2021
Merged

[HDRP] Fix volume component nullref #3644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb69e73
Fixed nullref when adding a volume component in a Volume profile asset
alelievr Feb 24, 2021
dcbd6c3
Updated changelog
alelievr Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions com.unity.render-pipelines.core/Editor/Volume/VolumeComponentListEditor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,17 +355,17 @@ internal void AddComponent(Type type)
var componentProp = m_ComponentsProperty.GetArrayElementAtIndex(m_ComponentsProperty.arraySize - 1);
componentProp.objectReferenceValue = component;

// Create & store the internal editor object for this effect
CreateEditor(component, componentProp, forceOpen: true);

m_SerializedObject.ApplyModifiedProperties();

// Force save / refresh
if (EditorUtility.IsPersistent(asset))
{
EditorUtility.SetDirty(asset);
AssetDatabase.SaveAssets();
}

// Create & store the internal editor object for this effect
CreateEditor(component, componentProp, forceOpen: true);

m_SerializedObject.ApplyModifiedProperties();
}

internal void RemoveComponent(int id)
Expand Down
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed decals in material debug display.
- Fixed WouldFitInAtlas that would previously return wrong results if any one face of a point light would fit (it used to return true even though the light in entirety wouldn't fit).
- Fixed loss of persistency of ratio between pivot position and size when sliding by 0 in DecalProjector inspector (case 1308338)
- Fixed nullref when adding a volume component in a Volume profile asset (case 1317156).

### Changed
- Changed Window/Render Pipeline/HD Render Pipeline Wizard to Window/Rendering/HDRP Wizard
Expand Down