Making the FrameSettingsAttribute field more robust. Using it in othe… #3700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r places to avoid caching the Obsoletes. Adding robustness in map query.
sebastienlagarde
approved these changes
Mar 1, 2021
sebastienlagarde
pushed a commit
that referenced
this pull request
Mar 1, 2021
…r places to avoid caching (#3700) the Obsoletes. Adding robustness in map query.
sebastienlagarde
added a commit
that referenced
this pull request
Mar 1, 2021
* Hdrp/fix 1299233 ies resize #3243 * Fixed an issue in the planar reflection probe convolution. #3668 * Making the FrameSettingsAttribute field more robust. Using it in other places to avoid caching (#3700) the Obsoletes. Adding robustness in map query. * [HDRP] Merge Hd/bugfix #3687 Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com>
sebastienlagarde
pushed a commit
that referenced
this pull request
Mar 3, 2021
…r places to avoid caching (#3700) the Obsoletes. Adding robustness in map query.
sebastienlagarde
added a commit
that referenced
this pull request
Mar 4, 2021
* [XPipeline]Fix crash on VolumeComponentWithQualityEditor when the current Pipeline is not HDRP #3643 * Fixed an issue in the planar reflection probe convolution. #3668 * Merge Hd/bugfix #3680 * Fix keyword backport (#3688) * Fix keyword backport * reenable test * [HDRP] Merge Hd/bugfix #3687 * Making the FrameSettingsAttribute field more robust. Using it in other places to avoid caching (#3700) the Obsoletes. Adding robustness in map query. * Avoid unnecessary RenderGraphBuilder.ReadTexture in the "Set Final Target" pass. #3707 * Update CHANGELOG.md * update double sided normal * Updated distortion description and distortion blur default value (#3721) Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: victorsclui <34995714+victorsclui@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix a crash in IL2CPP introduced by a previous PR. Doing a safe check on frame settings name attributes. Ensuring that other systems are using the cached attribute name list.
Testing status
Currently testing ps4 player il2cpp
Comments to reviewers
Crash occurs because il2cpp treats enums slightly differently, not as ints. Currently testing the exact test that failed to ensure this %100 fixes the issue.