[Universal] [2021.1 Backport] Make sure upgrading to Universal RP 2021 does not change Spot Light shadow resolutions #3832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dditionalLightData.AdditionalLightsShadowMinimumResolution
…e Spot Light shadow resolutions (internal ticket https://fogbugz.unity3d.com/f/cases/1316540 )
Wilfrid-Unity
requested review from
Verasl,
eh-unity,
lukaschod and
nigeljw-unity
|
It appears that you made a non-draft PR! |
…lues if it seems that they have never been customized (@Verasl suggestion)
…ltShadowResolutionTier... constant definitions outside of #if UNITY_EDITOR block
…nsparentReceiveShadow spot light shadow resolution to higher tier to match previous settings
… (comment)) (cherry picked from commit 82f939d)
…ith the one in 2021.2 pull request - see conversation #3831 (comment)
…shadow-resolution-auto-upgrade
…eiveShadow spot light shadow resolution to higher tier to match previous settings
|
Everything looks OK on both 2021.2 and 2021.1, I'm merging the pull requests. |
Wilfrid-Unity
deleted the
2021.1/universal/additional-light-shadow-resolution-auto-upgrade
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
#2126 added to Universal RP support for custom shadow resolution for additional lights.
When a Universal RP project is upgraded to a Universal RP package containing those changes, its UniversalRenderPipeline Assets get new "Shadow Resolution Tiers" fields added with default values 256/512/1024 ; and its spot light shadows get assigned the lowest tier resolution.
The lower resolution might cause the visual quality of spot light shadows in a project to look worse after the upgrade.
This pull request ensures that after upgrade, spot light shadows will keep using the same resolution.
This is done by using the highest tier resolution as default.
Taking inspiration from@Verasl suggestion, during upgrade the 3 tier resolutions are also modified according to the additional light shadow atlas resolution set in the asset (respectively: full-res, half-res, quarter res if possible).
Testing status
In a test scene based on UniversalRP template scene added with shadowed spot lights, I locally checked that the changes in this pull request effectively conserve spot light shadow resolutions after the upgrade to Unity 2021.
Comments to reviewers
Effort tracked by internal ticket https://fogbugz.unity3d.com/f/cases/1316540
2021.2 Main pull-request: #3831