[VFX] Fix compilation with builtin renderpipeline #3950
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, we won't fix this. |
sebastienlagarde
deleted the
vfx/fix/1308481-compilation-failing-with-cginc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix compilation issue with built-in render pipeline when
UnityCG.incandcom.unity.render-pipelines.core/ShaderLibrary/Common.hlslare both included.Testing status
Tested repro project locally from https://fogbugz.unity3d.com/f/cases/1308481/
Comments to reviewers
I'm not sure we should really do this : BRP isn't officially supported with VFXGraph.
This issue has been introduced by this change : #3443