Skip to content

Shader abstraction cleanup #3443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 25, 2021
Merged

Shader abstraction cleanup #3443

merged 3 commits into from
Feb 25, 2021

Conversation

robinb-u3d
Copy link
Contributor

Purpose of this PR

  • Cleans up some of the shader abstractions we use.
  • Note: This also adds a dependency from the visual effect graph to the core render-pipelines package to enable the use of our shader abstraction layer there. Is this dependency valid to backport down to 2019.4?

Testing status

  • Local testing with the HDRP template.
  • Contact shadows have been tested before and after the change to ensure it applies the same optimizations.

@sebastienlagarde sebastienlagarde marked this pull request as ready for review February 25, 2021 12:48
@sebastienlagarde sebastienlagarde merged commit 253750f into master Feb 25, 2021
@sebastienlagarde sebastienlagarde deleted the abstraction-cleanup branch February 25, 2021 15:05
sebastienlagarde pushed a commit that referenced this pull request Feb 28, 2021
@robinb-u3d @sebastienlagarde
[HDRP backport 10.x.x] Shader abstraction cleanup #3443
c1418f5
@sebastienlagarde sebastienlagarde mentioned this pull request Feb 28, 2021
Merged
sebastienlagarde added a commit that referenced this pull request Feb 28, 2021
@sebastienlagarde @robinb-u3d
[HDRP backport 10.x.x] Shader abstraction cleanup #3443 (#3679)
23b583c 
* [HDRP backport 10.x.x] Shader abstraction cleanup #3443

* Update package.json

Co-authored-by: robinb-u3d <robinb-u3d@users.noreply.github.com>
sebastienlagarde pushed a commit that referenced this pull request Mar 3, 2021
@robinb-u3d @sebastienlagarde
Shader abstraction cleanup #3443
4b61fbb
@sebastienlagarde sebastienlagarde mentioned this pull request Mar 3, 2021
Merged
sebastienlagarde added a commit that referenced this pull request Mar 3, 2021
@sebastienlagarde @anisunity
@FrancescoC-unity @JordanL8 @brandon-unity3d @NetteVI @Vic-Cooper @robinb-u3d
[Backport 2021.1][HDRP] Misc HDRP PRs (#3749)
0462902 
* Fix a flickering issue related to moving shadow receivers (case 1302392) and a refactoring to avoid computing the same value for every effect. #3039

* The RTAO's history is now discarded if the occlusion caster was moving (case 1303418). #3343

* Update CHANGELOG.md

* Add new API to CachedShadowManager and fix WouldFitInAtlas #3387

* Added master stack documentation for HDRP (#3388)

* Added landing page and context/blocks overview page

* Added vertex context page and snippets

* Added the fragment context page and supporting snippets

* Added the decal master stack and the contexts intro

* Updated toc

* Added vertex context doc

* Update TableOfContents.md

* Added unlit doc

* Added lit master stack doc

* Added eye master stack doc

* Added fabric master stack

* added hair master stack

* Added stacklit master stack

* Added snippets to support shader stack work

* Fixed some formatting bugs

* Removed old links

* Updated links

* formatting

Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix Sub-shadow rendering with cached shadows + Fix PCSS filtering issues on first frame or cached shadows #3396

* Reset ambient probe upon switching to very different skies bis #3423

* HDRP Graphic Test Fixes for Metal (#3408)

* Fixed the metal pipeline creation error message and updated several gfx test images.

* Rearranged LightData definition to workaround area lights not rendering issue on Intel GPUs on Catalina

* Updated 2501 reference image for Metal with the area light fix

* Updated 1550 and 2010 on Metal as previous were incorrect due to area light issue

Co-authored-by: Jeannette Yu <jeannette.yu@unity3d.com>

* Custom Pass error message fix (#3424)

Typo in DrawRenderersCustomPass error message. Fixed a few other typos in this section too :D

* Add Unity version to what's new 11 (#3432)

* Update whats-new-11.md

* Updated the table of contents

* Shader abstraction cleanup #3443

* Some leftover caused by master merge (#3456)

* Fix multiple any hit occuring on transparent objects (case 1294927). #3471

* Colored Shadows update (#3486)

* Colored Shadows update

Included new information in the Color Shadow property description to tell the user that the Material's  Refraction Model has to be set to Thin, Box or Sphere for it to work.

* Fixed typo

Removed the "the" :D

* Revert "Fix multiple any hit occuring on transparent objects (case 1294927). #3471"

This reverts commit 0587177.

* Update 1219_Lit_Light_on_Tesselation.png

Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com>
Co-authored-by: Brandon Fogerty <34072588+brandon-unity3d@users.noreply.github.com>
Co-authored-by: Jeannette Yu <jeannette.yu@unity3d.com>
Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com>
Co-authored-by: robinb-u3d <robinb-u3d@users.noreply.github.com>
@PaulDemeulenaere PaulDemeulenaere mentioned this pull request Mar 22, 2021
Closed
sebastienlagarde pushed a commit that referenced this pull request Mar 25, 2021
@robinb-u3d @sebastienlagarde
Shader abstraction cleanup #3443
c2cefd9
@loopervfx loopervfx mentioned this pull request May 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julienf-unity julienf-unity julienf-unity approved these changes

+1 more reviewer

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported-7.x backported-10.x backported-2021.1 HDRP vfx

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robinb-u3d @sebastienlagarde @julienf-unity