-
Notifications
You must be signed in to change notification settings - Fork 855
Hd/new-draw-api #4190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hd/new-draw-api #4190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a section in upgrade guide (the document name upgrade-guide-2021-2.md) to say the change done in the shader, thanks
Please add changelog + upgrade guide thanks |
Also please update the PR description, remove all default text, briefly explain what the PR does and what testing took place. Thank you |
# Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md
# Conflicts: # com.unity.render-pipelines.core/CHANGELOG.md # com.unity.render-pipelines.high-definition/CHANGELOG.md
Any update on this PR? |
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP URP Shader Graph SRP Core Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only issues that stands seems to be the Universal issue listed above. Tested RenderMesh() and RenderMeshInstanced() calls with all MotionVectorGeneration modes. HDRP/Lit, Fabric, LayeredLitTessellation, Unlit and basic SG Lit shaders, not other issues found. |
…nitions (caused URP issues)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! Switching pipelines to URP, HDRP and back to built-in works without any issues now.
Note for URP Qa: Change on urp side is just addition of those define I will merge this PR to be part of SRP to core PR happening tomorrow. If you have any comment post merge, please put it here and we will adress them. Thanks |
This breaks BuiltIn. Were the tests run (they don't appear in the PR details and I can't find them on yamato)? |
Purpose of this PR
Enables motion vector rendering when using Graphics.RenderMeshInstanced()
Testing status
Tested motion vectors are properly rendered for RenderMesh() and RenderMeshInstanced() with a local HDRP project
Comments to reviewers
Requires landed C++ PR #126439 ("New draw API" for 2021.2)