Skip to content

Conversation

jessebarker
Copy link
Contributor

@jessebarker jessebarker commented Jul 28, 2021


Purpose of this PR

#4190 added some new matrix property macros to support proper motion vector behavior for SRPs. Unfortunately, the macros reference matrix properties that are not defined for the built-in render pipeline. This PR defines them to return a 0 matrix (as the feature work is not intended to support builtin, this should be fine).


Testing status

Local testing to ensure there are no errors in SpaceTransforms.hlsl.

Yamato as below.


Comments to reviewers

This change went in earlier today, so there isn't even an available build with it yet.

@jessebarker jessebarker requested a review from a team as a code owner July 28, 2021 15:56
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

Shader Graph
/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_2021.2
Depending on your PR, you may also want
/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_2021.2
/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

#define UNITY_MATRIX_I_M unity_WorldToObject
#define UNITY_MATRIX_I_P (float4x4)0
#define UNITY_MATRIX_I_VP (float4x4)0
#define UNITY_PREV_MATRIX_I_M unity_MatrixPreviousMI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these PREV matrices just be defined to the current ones instead? This way things should kind of work (I think) instead of not at all?

Copy link
Contributor

@joshua-davis joshua-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should at least be fine to get us green

@jessebarker jessebarker merged commit 1766d5c into master Jul 28, 2021
@jessebarker jessebarker deleted the sg-builtin-fix-prev-matrix branch July 28, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants