Add skeleton for new shadow setting #4344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ${VFXHDRPForwardDefines} | ||
| #pragma multi_compile USE_FPTL_LIGHTLIST USE_CLUSTERED_LIGHTLIST | ||
| #pragma multi_compile SHADOW_LOW SHADOW_MEDIUM SHADOW_HIGH | ||
| #pragma multi_compile SHADOW_LOW SHADOW_MEDIUM SHADOW_HIGH SHADOW_VERY_HIGH |
There was a problem hiding this comment.
Not sure why it looks differently indented here, can't see to get this to change locally with fork :/
There was a problem hiding this comment.
Maybe running the formatting tool can work?
There was a problem hiding this comment.
I did try but did not work :-(
sebastienlagarde
approved these changes
Apr 27, 2021
Will add soon |
I was wondering, shall we update now or when there will be an actual difference? As of now it'd be a bit silly to say "Very High: it is the same as High" |
|
good poitn, ok let's merge this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new shadow quality tier to allow the work for PCSS in area lights.
Also added abstraction for AREA_LIGHT_FILTERING so that it can be changed to slot in a new method.
I did test the change by running all tests locally and they are all green.
For the time being Very High and High are exactly the same (waiting for @robertcupisz PR)