-
Notifications
You must be signed in to change notification settings - Fork 855
Disable shadow filtering : very high quality and clean distortion code #5642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
// TEMP: HDShadowFilteringQuality.VeryHigh - This filtering mode is not ready so disabling in UI | ||
// To re-enable remove the wo following light and re-enable the third one | ||
int value = EditorGUILayout.IntPopup(Styles.filteringQuality, serialized.renderPipelineSettings.hdShadowInitParams.shadowFilteringQuality.enumValueIndex, Styles.shadowFilteringNames, Styles.shadowFilteringValue); | ||
serialized.renderPipelineSettings.hdShadowInitParams.shadowFilteringQuality.enumValueIndex = value; | ||
//EditorGUILayout.PropertyField(serialized.renderPipelineSettings.hdShadowInitParams.shadowFilteringQuality, Styles.filteringQuality); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to disable the entry maybe is better to do it this way:
// TEMP: HDShadowFilteringQuality.VeryHigh - This filtering mode is not ready so disabling in UI | |
// To re-enable remove the wo following light and re-enable the third one | |
int value = EditorGUILayout.IntPopup(Styles.filteringQuality, serialized.renderPipelineSettings.hdShadowInitParams.shadowFilteringQuality.enumValueIndex, Styles.shadowFilteringNames, Styles.shadowFilteringValue); | |
serialized.renderPipelineSettings.hdShadowInitParams.shadowFilteringQuality.enumValueIndex = value; | |
//EditorGUILayout.PropertyField(serialized.renderPipelineSettings.hdShadowInitParams.shadowFilteringQuality, Styles.filteringQuality); | |
serialized.renderPipelineSettings.hdShadowInitParams.shadowFilteringQuality.intValue = (int)(HDShadowFilteringQuality)EditorGUILayout.EnumPopup( | |
Styles.filteringQuality, | |
(HDShadowFilteringQuality)serialized.renderPipelineSettings.hdShadowInitParams.shadowFilteringQuality.intValue, | |
e => (HDShadowFilteringQuality)e != HDShadowFilteringQuality.VeryHigh, /* TEMP: HDShadowFilteringQuality.VeryHigh - This filtering mode is not ready so disabling in UI */ | |
false); |
It will still be visible, but users won't be able to select it from the UI, Also you do not need the GUIContents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion and it is what I wanted to do initially but don't know how, so good. But it is preferable to hide it fully, otherwise we will get various question about how to enable it. i.e users will think there is a settings somewhere to enable it whereas the feature is not implemented at all...
Purpose of this PR
This PR disable vrey high quality filtering mode for shadow in UI as it is not implemented
(original PR adding it are:
#4344
#4482
and
#4485
)
Waiting for #4037
This PR also clean distortion code in lit shader. The code in LitProperties was causing issue with Hybrid renderer
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.