Skip to content

Add support for lighting full screen debug mode for HDRP tests #4367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Add support for lighting full screen debug mode for HDRP tests #4367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f047909
Add support for lighting full screen debug mode for tests
remi-chapelain Apr 28, 2021
2be1397
changelog
remi-chapelain Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Added support for alpha channel in FXAA (case 1323941).
- Added Speed Tree 8 shader graph as default Speed Tree 8 shader for HDRP.
- Added the multicompile for dynamic lightmaps to support enlighten in ray tracing (case 1318927).
- Added support for lighting full screen debug mode in automated tests.

### Fixed
- Fixed Intensity Multiplier not affecting realtime global illumination.
Expand Down
5 changes: 5 additions & 0 deletions com.unity.render-pipelines.high-definition/Runtime/Debug/DebugDisplay.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,11 @@ internal void ResetExclusiveEnumIndices()
/// <summary>List of Full Screen Rendering Debug mode values.</summary>
public static int[] renderingFullScreenDebugValues => s_RenderingFullScreenDebugValues;

/// <summary>List of Full Screen Lighting Debug mode names.</summary>
public static GUIContent[] lightingFullScreenDebugStrings => s_LightingFullScreenDebugStrings;
/// <summary>List of Full Screen Lighting Debug mode values.</summary>
public static int[] lightingFullScreenDebugValues => s_LightingFullScreenDebugValues;

internal DebugDisplaySettings()
{
FillFullScreenDebugEnum(ref s_LightingFullScreenDebugStrings, ref s_LightingFullScreenDebugValues, FullScreenDebugMode.MinLightingFullScreenDebug, FullScreenDebugMode.MaxLightingFullScreenDebug);
Expand Down
4 changes: 3 additions & 1 deletion com.unity.testing.hdrp/Scripts/DebugViewController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ public enum SettingType { Material, Lighting, Rendering }

[Header("Lighting")]
[SerializeField] bool lightlayers = false;
[SerializeField] int lightingFullScreenDebugMode = 0;

[ContextMenu("Set Debug View")]
public void SetDebugView()
Expand All @@ -33,7 +34,8 @@ public void SetDebugView()
case SettingType.Lighting:
hdPipeline.debugDisplaySettings.SetDebugLightLayersMode(lightlayers);
hdPipeline.debugDisplaySettings.data.lightingDebugSettings.debugLightLayersFilterMask = (DebugLightLayersMask)0b10111101;
break;
hdPipeline.debugDisplaySettings.SetFullScreenDebugMode((FullScreenDebugMode) lightingFullScreenDebugMode);
break;
case SettingType.Rendering:
hdPipeline.debugDisplaySettings.SetFullScreenDebugMode((FullScreenDebugMode) fullScreenDebugMode);
break;
Expand Down
5 changes: 4 additions & 1 deletion com.unity.testing.hdrp/Scripts/Editor/DebugViewController_Editor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ public class DebugViewController_Editor : Editor

SerializedProperty s_gBuffer;
SerializedProperty s_fullScreenDebugMode;
SerializedProperty s_lightingFullScreenDebugMode;

SerializedProperty s_lightlayers;

Expand All @@ -21,6 +22,7 @@ public void OnEnable()

s_gBuffer = serializedObject.FindProperty("gBuffer");
s_fullScreenDebugMode = serializedObject.FindProperty("fullScreenDebugMode");
s_lightingFullScreenDebugMode = serializedObject.FindProperty("lightingFullScreenDebugMode");
s_lightlayers = serializedObject.FindProperty("lightlayers");
}

Expand All @@ -45,7 +47,8 @@ public override void OnInspectorGUI()

case DebugViewController.SettingType.Lighting:
s_lightlayers.boolValue = GUILayout.Toggle(s_lightlayers.boolValue, "Light Layers Visualization");
break;
s_lightingFullScreenDebugMode.intValue = EditorGUILayout.IntPopup(new GUIContent("Fullscreen Debug Mode"), s_lightingFullScreenDebugMode.intValue, DebugDisplaySettings.lightingFullScreenDebugStrings, DebugDisplaySettings.lightingFullScreenDebugValues);
break;

case DebugViewController.SettingType.Rendering:
s_fullScreenDebugMode.intValue = EditorGUILayout.IntPopup(new GUIContent("Fullscreen Debug Mode"), s_fullScreenDebugMode.intValue, DebugDisplaySettings.renderingFullScreenDebugStrings, DebugDisplaySettings.renderingFullScreenDebugValues);
Expand Down