Add support for lighting full screen debug mode for HDRP tests #4367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienlagarde
approved these changes
Apr 28, 2021
|
Just to be sure I understand, this is just exposing the API, then we will add test in a separete PR? |
Yes, waiting for merge to add the tests |
TomasKiniulis
approved these changes
Apr 29, 2021
sebastienlagarde
deleted the
hd/add-lighting-fullscreen-debug-mode-support
branch
sebastienlagarde
pushed a commit
that referenced
this pull request
May 3, 2021
sebastienlagarde
added
backported-10.x
backported-2021.1
and removed
needs-backport-10.x
needs-backport-2021.1
labels
sebastienlagarde
pushed a commit
that referenced
this pull request
May 3, 2021
sebastienlagarde
added a commit
that referenced
this pull request
May 5, 2021
* [HDRP][DXR] Add coverage for lighting full screen debug mode in DXR Tests Projects (#4391) * 5 new lighting debug mode scene * RTAO + SSShadows * build settings * Light Cluster scene * Contact shadows correct captures using BackBuffer * ContactShadow scene * forgot meta files * Add coverage for path tracer alpha channel support (#4393) * add-pt-alpha-automated-test * Tidy up 5001 scene * Disable DXR XR test (#4403) * Add support for lighting full screen debug mode for HDRP tests #4367 * Fix automated tests * upgrade path tracing alpha test * 5001 updated unreadable image * disable DXR XR 2005 Co-authored-by: Rémi Chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
sebastienlagarde
added a commit
that referenced
this pull request
May 29, 2021
* [HDRP][DXR] Add coverage for lighting full screen debug mode in DXR Tests Projects (#4391) * 5 new lighting debug mode scene * RTAO + SSShadows * build settings * Light Cluster scene * Contact shadows correct captures using BackBuffer * ContactShadow scene * forgot meta files * Added information about ray tracing light culling (#4392) * Added ray tracing light culling section and moved a couple of things around * Update Ray-Tracing-Getting-Started.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added more pages to help users with runtime usage #4394 * Disable DXR XR test (#4403) * Add support for lighting full screen debug mode for HDRP tests #4367 * Update CHANGELOG.md * Fix automated tests * upgrade path tracing alpha test * 5001 updated unreadable image * update failing test scene * Update failing scenes * Changing geometry in 708/711 tests It was not appearing for some reasons * Tentative fix * Debug 'debug test scene' * Debug * new DebugDisplaySettings * revert static variable to private * Disable debug test scenes and reverting changes Co-authored-by: Rémi Chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
pastasfuture
pushed a commit
that referenced
this pull request
Aug 20, 2021
* [HDRP][DXR] Add coverage for lighting full screen debug mode in DXR Tests Projects (#4391) * 5 new lighting debug mode scene * RTAO + SSShadows * build settings * Light Cluster scene * Contact shadows correct captures using BackBuffer * ContactShadow scene * forgot meta files * Added information about ray tracing light culling (#4392) * Added ray tracing light culling section and moved a couple of things around * Update Ray-Tracing-Getting-Started.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added more pages to help users with runtime usage #4394 * Disable DXR XR test (#4403) * Add support for lighting full screen debug mode for HDRP tests #4367 * Update CHANGELOG.md * Fix automated tests * upgrade path tracing alpha test * 5001 updated unreadable image * update failing test scene * Update failing scenes * Changing geometry in 708/711 tests It was not appearing for some reasons * Tentative fix * Debug 'debug test scene' * Debug * new DebugDisplaySettings * revert static variable to private * Disable debug test scenes and reverting changes Co-authored-by: Rémi Chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
After finding this issue, I discovered that we didn't have coverage for the lighting full screen debug mode.
This PR will allow us to add automated test to cover Lighting Full Screen Debug Mode and prevent future regression of the aforementionned issue and avoid doing it by hand in the smoke test phases.
Testing status
Comments to reviewers
I needed to add two accessible variables in DebugDisplay.cs, not sure if this can be done differently.