Skip to content

Conversation

NicoLeyman
Copy link
Contributor

Purpose of this PR

Depth Priming recently landed in master. One of the limitations was that we couldn't use when MSAA was enabled on Vulkan due to no depth resolve support. Since this support has now landed this limitation is no longer valid.
This limitation wasn't mentioned in the documentation.


Testing status

Manually verified that depth priming now works on Vulkan when MSAA is enabled.
Results in a 3% CPU and 7.5% GPU speedup w/ 8x MSAA.


Comments to reviewers

@NicoLeyman NicoLeyman requested review from a team as code owners May 28, 2021 08:09
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

Copy link
Contributor

@erikabar erikabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR was already tested by dev, approving

@github-actions
Copy link

github-actions bot commented Sep 6, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@manuele-bonanno manuele-bonanno requested review from manuele-bonanno and removed request for jonuuukas September 21, 2021 07:16
@phi-lira phi-lira changed the base branch from master to universal/staging October 6, 2021 14:19
@phi-lira phi-lira merged commit 48a6a1a into universal/staging Oct 6, 2021
@phi-lira phi-lira deleted the urp/depth-priming-vulkan-msaa branch October 6, 2021 14:20
@phi-lira phi-lira mentioned this pull request Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants