Skip to content

[URP] Enable Depth Priming on Vulkan w/ MSAA #4699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 6, 2021
Merged

[URP] Enable Depth Priming on Vulkan w/ MSAA #4699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2fc65ac
Enable Depth Priming on Vulkan w/ MSAA
NicoLeyman May 28, 2021
13b2e16
Update CHANGELOG.md
NicoLeyman May 28, 2021
d595fb8
Merge branch 'master' into urp/depth-priming-vulkan-msaa
phi-lira Sep 6, 2021
2083b17
Merge branch 'master' into urp/depth-priming-vulkan-msaa
phi-lira Oct 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion com.unity.render-pipelines.universal/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

### Added
- Added public api and updated docs for Light2D shape properties.
- Depth Texture setting for Overlay Camera.
- Added Depth Texture setting for Overlay Camera.
- Added Depth Priming support for Vulkan with MSAA.

### Changed

Expand Down
3 changes: 0 additions & 3 deletions com.unity.render-pipelines.universal/Runtime/UniversalRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,9 +509,6 @@ public override void Setup(ScriptableRenderContext context, ref RenderingData re
bool useDepthPriming = (m_DepthPrimingRecommended && m_DepthPrimingMode == DepthPrimingMode.Auto) || (m_DepthPrimingMode == DepthPrimingMode.Forced);
useDepthPriming &= requiresDepthPrepass && (createDepthTexture || createColorTexture) && m_RenderingMode == RenderingMode.Forward && (cameraData.renderType == CameraRenderType.Base || cameraData.clearDepth);

// Temporarily disable depth priming on certain platforms such as Vulkan because we lack proper depth resolve support.
useDepthPriming &= SystemInfo.graphicsDeviceType != GraphicsDeviceType.Vulkan || cameraTargetDescriptor.msaaSamples == 1;

if (useRenderPassEnabled || useDepthPriming)
{
createDepthTexture |= createColorTexture;
Expand Down