-
Notifications
You must be signed in to change notification settings - Fork 855
[7.x.x] Removal of Graphics Test Framework #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The short answer is, "I approve!" See below for my notes about each of the tests that @sophiaaar disabled. I added a couple commits to 7.x.x/backport/testing/gtf-removal to re-enable a few of the these. The images for 018 and 019 changed very little, and XR devs are investigating similar image discrepancies for PR22 (shim removal); I believe it is best to update these two reference images for now. Test 020 needs work but that is my problem, not yours. I'm leaving it disabled for now. Tinkering with 020 in the Editor locally does not make me suspect any regressions in the code... I just need to fix my test. Here is my Yamato job for my most recent commit on 7.x.x/backport/testing/gtf-removal (b2fc70e): This job has ran for three hours and I need to sleep now. If it finishes green during Friday business hours in Europe, then I encourage you to merge commit b2fc70e. If this job ends with any failed tests, then I'm fine with you merging sophiaar's last commit 8653cc1. I approve, in either case. 017_xr_Particles_Additive 018_xr_Particles_Multiply 019_xr_Particles_AlphaBlend 020_xr_Lighting_ReflectionProbe 021_xr_Realtime_ReflectionProbe 022_xr_Static_Batching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving -- see my previous comment regarding the changesets I added and Yamato jobs in progress.
…ode only, since Standalone passed for these two tests on Yamato.
@sophiaaar I fixed tests 018 and 019 in commit 8cfd398. When you merge this PR, would you be willing to merge commit 8cfd398 which re-enables most of the tests that you originally disabled, and is green on Yamato here: |
This PR strayed too far from the target branch and became un-mergeable :( new PR at #531 |
Purpose of this PR
Backport of #32
Testing status
Manual Tests
Ran the project to ensure no errors occurred, but can't test fully on my Mac
Links
Yamato:
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/7.x.x%252Fbackport%252Ftesting%252Fgtf-removal
Comments to reviewers
Also disable tests 011, 017, 018, 019, 020, 021, 022 - fogbugz case will be made so these issues can be followed up on