Skip to content

Conversation

sophiaaar
Copy link
Contributor

@sophiaaar sophiaaar commented May 18, 2020

NEW PR - the old one was un-mergeable
Old PR: #474

Purpose of this PR

Backport of #32

Testing status

Yamato:
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/7.x.x%252Fbackport%252Fautomation%252Fgtf-removal

Comments to reviewers

@sophiaaar sophiaaar marked this pull request as ready for review May 18, 2020 13:50
@sophiaaar sophiaaar added yamato and removed HDRP labels May 18, 2020
@sebastienlagarde
Copy link
Contributor

2602_SSAO_FullRes 2601_SSAO_HalfRes and 1710_Decals_Normal_Patch result we can see on this PR is what we get sometime locally. Up to now it have always been stable on Yamato (until this PR :) ).
So guess it is ok. And guess we will disable them on 7.x.x/release

Copy link
Contributor

@DennisDeRykeUnity DennisDeRykeUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already approved the following PR. I assume this one has all the same code changes merged into a more recent commit of the parent branch.

#474

@sophiaaar sophiaaar merged commit d4b8598 into 7.x.x/release May 18, 2020
@sophiaaar sophiaaar deleted the 7.x.x/backport/automation/gtf-removal branch May 18, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants