Skip to content

Conversation

NicoLeyman
Copy link
Contributor

@NicoLeyman NicoLeyman commented Jun 3, 2021

Purpose of this PR

The recently landed PR adding Depth Priming didn't contain any automated test coverage. This PR aims to correct that by adding a new graphics test.
Since this test ran into an issue related to the recent swapbuffer changes this also contains a fix for that to allow the test to succeed.


Testing status

New graphics test added. Ref images are being added.

image

The test shows a set of boxes rendered with a camera stack, splitscreen rendering. Since Depth Priming can have fallout I opted to use some of the existing materials on the scene objects. SSAO and transparent materials are included and definitely need to stay part of the test.


Comments to reviewers

Code changes provided by Robin.

@NicoLeyman NicoLeyman requested a review from robin-demoor June 3, 2021 08:47
@NicoLeyman NicoLeyman requested review from a team as code owners June 3, 2021 08:47
@NicoLeyman NicoLeyman marked this pull request as draft June 3, 2021 08:47
@github-actions
Copy link

github-actions bot commented Jun 3, 2021

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

Comment on lines 32 to 41
public RenderTargetHandle GetBackBuffer()
{
return m_FirstIsBackBuffer ? RTA : RTB;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for RM: this class is internal, not breaking change to user.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have screenshots of ref images that were added in the PR.
Otherwise looks good.

@phi-lira phi-lira marked this pull request as ready for review September 21, 2021 07:15
Copy link
Contributor

@robin-demoor robin-demoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Sep 24, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Shader Graph
/jobDefinition/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk
Depending on your PR, you may also want
/jobDefinition/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_trunk
/jobDefinition/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@phi-lira phi-lira changed the base branch from master to universal/staging October 6, 2021 14:24
@phi-lira phi-lira merged commit 4d834d0 into universal/staging Oct 6, 2021
@phi-lira phi-lira deleted the urp/depth-priming-tests branch October 6, 2021 14:25
@phi-lira phi-lira mentioned this pull request Oct 6, 2021
phi-lira added a commit that referenced this pull request Oct 7, 2021
@phi-lira phi-lira restored the urp/depth-priming-tests branch October 7, 2021 18:59
@phi-lira
Copy link
Contributor

phi-lira commented Oct 7, 2021

This PR introduced the following error in ABV:
severity: Error
message: '' is an incorrect path for a scene file. BuildPlayer expects paths relative to the project folder.

@cdxntchou cdxntchou self-requested a review October 7, 2021 20:47
Copy link

@cdxntchou cdxntchou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can revert the ShaderGraph test reference images, they have been added to master already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants