-
Notifications
You must be signed in to change notification settings - Fork 855
Urp/depth priming tests #4769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Urp/depth priming tests #4769
Conversation
It appears that you made a non-draft PR! |
public RenderTargetHandle GetBackBuffer() | ||
{ | ||
return m_FirstIsBackBuffer ? RTA : RTB; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for RM: this class is internal, not breaking change to user.
com.unity.render-pipelines.universal/Runtime/UniversalRenderer.cs
Outdated
Show resolved
Hide resolved
TestProjects/UniversalGraphicsTest_Foundation/ProjectSettings/TagManager.asset
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have screenshots of ref images that were added in the PR.
Otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. URP Shader Graph Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
This PR introduced the following error in ABV: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can revert the ShaderGraph test reference images, they have been added to master already.
Purpose of this PR
The recently landed PR adding Depth Priming didn't contain any automated test coverage. This PR aims to correct that by adding a new graphics test.
Since this test ran into an issue related to the recent swapbuffer changes this also contains a fix for that to allow the test to succeed.
Testing status
New graphics test added. Ref images are being added.
The test shows a set of boxes rendered with a camera stack, splitscreen rendering. Since Depth Priming can have fallout I opted to use some of the existing materials on the scene objects. SSAO and transparent materials are included and definitely need to stay part of the test.
Comments to reviewers
Code changes provided by Robin.