-
Notifications
You must be signed in to change notification settings - Fork 855
Urp/depth priming tests #6062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Urp/depth priming tests #6062
Conversation
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. URP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
It appears that you made a non-draft PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
… into urp/depth-priming-tests
* Add 240 Depth Priming Gfx Test * Expand depth priming test to include camera stacking. * Swapbuffer: avoid 0 size, always pass commandbuffer to access RT * Fixes Depth Priming Test and cleanup of Tag Manager * Revert cmd buffer use during setup * Fix merge * Fix 240_DepthPriming overlay camera and disable canvas * Update 240_DepthPriming reference images * Move 240_Depth priming test to PostPro instead of Foundation project. * Add 240 Depth priming to project build settings * Add lighting data for 240 Depth Priming * 240_DepthPriming reference images added. * Disable XR for 240_DepthPriming since it does not work well with overlay cameras * Fixed mobile 240_DepthPriming ref images. * Revert unwanted shadergraph ref image changes. (caused by master merge ?) * Remove missing 240_DepthPriming scene from Foundation build settings. Co-authored-by: Robin De Moor <robin.demoor@unity3d.com>
Re-try of this PR: #4769
Original PR added a small fix and test coverage for Depth Priming.
The PR had an issue when the test was moved to a different project but that has been fixed.
Some redundant ref images that stuck around after a master merge have been removed.
Master has been merged.