Skip to content

Conversation

NicoLeyman
Copy link
Contributor

Re-try of this PR: #4769
Original PR added a small fix and test coverage for Depth Priming.

The PR had an issue when the test was moved to a different project but that has been fixed.
Some redundant ref images that stuck around after a master merge have been removed.
Master has been merged.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@NicoLeyman NicoLeyman added ready-to-merge Add this tag whenever your PR is ready to be merged. i.e, non draft, all reviewers approved, ABV and removed testing labels Oct 19, 2021
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

Copy link
Contributor

@eh-unity eh-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@phi-lira phi-lira changed the base branch from master to universal/staging October 26, 2021 15:29
@phi-lira phi-lira merged commit e259b25 into universal/staging Oct 26, 2021
@phi-lira phi-lira deleted the urp/depth-priming-tests branch October 26, 2021 15:29
phi-lira pushed a commit that referenced this pull request Nov 9, 2021
* Add 240 Depth Priming Gfx Test

* Expand depth priming test to include camera stacking.

* Swapbuffer: avoid 0 size, always pass commandbuffer to access RT

* Fixes Depth Priming Test and cleanup of Tag Manager

* Revert cmd buffer use during setup

* Fix merge

* Fix 240_DepthPriming overlay camera and disable canvas

* Update 240_DepthPriming reference images

* Move 240_Depth priming test to PostPro instead of Foundation project.

* Add 240 Depth priming to project build settings

* Add lighting data for 240 Depth Priming

* 240_DepthPriming reference images added.

* Disable XR for 240_DepthPriming since it does not work well with overlay cameras

* Fixed mobile 240_DepthPriming ref images.

* Revert unwanted shadergraph ref image changes. (caused by master merge ?)

* Remove missing 240_DepthPriming scene from Foundation build settings.

Co-authored-by: Robin De Moor <robin.demoor@unity3d.com>
@phi-lira phi-lira mentioned this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Add this tag whenever your PR is ready to be merged. i.e, non draft, all reviewers approved, ABV universal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants