[Universal][XR] Reducing VR latency with Late Latching #4807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w late latching command buffer commands to mark/unmark URP stereo matrices such as stereo view and projection matrices for use in late latching.
…Begin/End LateLatching.
…erties. Refactored mark/unmark late latching into separate functions: Mark/UnmarkLateLatchShaderProperties.
mikesfbay
changed the title
erikabar
approved these changes
Jun 8, 2021
thomas-zeng
reviewed
Jun 8, 2021
amaestas13
approved these changes
Jun 11, 2021
There was a problem hiding this comment.
Tested on Quest and Quest 2
Ran manual Functional/Acceptance testing . Verified Dev Provided test projects and tested for regressions.
Ran multiple passes with these changes.
Last Verification for regressions on commit a281d5b
Tested on
Version: 2021.2.0a21.2949
Revision: trunk 75138d5880a6
Built: Tue, 08 Jun 2021 14:22:40 GMT
thomas-zeng
approved these changes
Jun 15, 2021
phi-lira
approved these changes
Jun 16, 2021
|
@mikesfbay which version of Unity this PR requires? Seems like we need to bump minimum Unity version. |
|
@phi-lira The minimum version is 2021.2.0a21 |
esmelusina
approved these changes
Jun 18, 2021
|
@phi-lira After min version bump, yamato results are the same as master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Add late latching support for camera and render pass. Use new late latching command buffer commands to mark/unmark URP stereo matrices such as stereo view and projection matrices for use in late latching.
For a detailed late latching overview, please see design doc:
Testing status
Tested late latching on Quest using template scene.
Comments to reviewers
Matching trunk PR: https://ono.unity3d.com/unity/unity/pull-request/126011/_/xr/late-latching-urp