Fix cubemap static preview + remove custom inspector (#2041) #5158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubacupisz
approved these changes
Jul 19, 2021
alelievr
approved these changes
Jul 19, 2021
|
Hi, please poke when the mentionned C++ PR land. |
|
@sebastienlagarde The core PR has landed just this morning. |
pema99
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR is a backport of #2041. The reason for backporting this is to fix case 1349126 which is a HUP regression only affecting 2019.4. The issue lies within the custom cubemap inspector this version of HDRP currently uses, which was later replaced with the builtin inspector in the PR being backported.
Backporting this PR without changes to core would cause a regression, as 2019.4 does not currently have an exposure slider on the builtin cubemap inspector, but the custom HDRP inspector does. This was fixed here https://ono.unity3d.com/unity/unity/pull-request/103240/_/lighting/bugfix/1226322 (case 1226322), and is in the process of being backported to 2019.4 here https://ono.unity3d.com/unity/unity/pull-request/129435/_/2019.4/lighting/bugfix/1226322 (case 1349126).
Thus, this fix cannot land before the fix to core 2019.4 lands.
Testing status
The fixes (both that being backported, and the HUP regression) were verified manually. No automated tests added.
Comments to reviewers
cherry-pick did not cause conflicts with the exception of changes to the changelog.