Skip to content

Fix yaml generator on mac #5186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2021
Merged

Fix yaml generator on mac #5186

merged 2 commits into from
Jul 22, 2021

Conversation

theopnv
Copy link
Contributor

@theopnv theopnv commented Jul 21, 2021

Purpose of this PR

  • Changed the way we call the yaml generator in the generate_yml_files.py script. We are now passing the command as a list instead of a string (thread.
  • We are also now calling python3 explicitly because on most macos setups python2.7 is the default

Testing status

Tested the generation locally on mac OS big sur

@theopnv theopnv requested a review from a team as a code owner July 21, 2021 12:27
@github-actions github-actions bot added the sdet label Jul 21, 2021
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@theopnv theopnv merged commit 83f737c into master Jul 22, 2021
@theopnv theopnv deleted the yaml-generator/macos-fixes branch July 22, 2021 08:36
theopnv pushed a commit that referenced this pull request Jul 26, 2021
@theo-at-unity
Backport #5186
5a74944
@theopnv theopnv mentioned this pull request Jul 26, 2021
Merged
theopnv pushed a commit that referenced this pull request Jul 26, 2021
@theo-at-unity
Backport #5186
6f3ab66
@theopnv theopnv mentioned this pull request Jul 26, 2021
Merged
theopnv pushed a commit that referenced this pull request Jul 26, 2021
@theo-at-unity
Backport #5186
28fcf8e
@theopnv theopnv mentioned this pull request Jul 26, 2021
Merged
theopnv pushed a commit that referenced this pull request Jul 28, 2021
[7xx] SDET Backports (#5217)
c88577b 
* Backport #5198

* Backport #5186

* Remove dependency on pre-pack step for templates
theopnv pushed a commit that referenced this pull request Jul 28, 2021
[10.x.x] SDET Backports (#5216)
4d493d3 
* Backport #5198

* Backport #5186

* Delete green revisions file

* Remove green revisions script

* Remove dependency on pre-pack step for templates

* Remove unused fields in editor metafile

* Remove unused fields from shared metafile

Co-authored-by: Liis Kivistik <liis.kivistik@unity3d.com>
theopnv pushed a commit that referenced this pull request Jul 28, 2021
[2021.1] SDET backports (#5215)
2acec83 
* Backport #5198

* Backport #5186

* Delete green revisions file

* Remove green revisions script

* Update templates pipeline config

* Remove unused fields from metafiles

Co-authored-by: Liis Kivistik <liis.kivistik@unity3d.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kivistikliis kivistikliis kivistikliis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported-7.x backported-10.x backported-2021.1 sdet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@theopnv @kivistikliis