Skip to content

Conversation

theopnv
Copy link
Contributor

@theopnv theopnv commented Jul 22, 2021

Purpose of this PR

When running the pre-pack step in the templates publish pipelines, we are calling unity.exe <path-to-template>. Unlike utr, it doesn't generate a testreport.html, so when it fails we currently don't have any logs.
This PR is adding the Editor.log file to the artifacts zip for easier investigation.

Needs https://github.cds.internal.unity3d.com/unity/gfx-sdet-tools/pull/57

Testing

Checked that the Editor.log file appears in the artifacts of the pre-pack steps of that pipeline https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Ftemplates%252Fadd-log/.yamato%252F_templates.yml%2523all_template_ci_trunk/7781055/job

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@theopnv theopnv merged commit facc4ce into master Jul 26, 2021
@theopnv theopnv deleted the yamato/templates/add-log branch July 26, 2021 07:53
theopnv pushed a commit that referenced this pull request Jul 26, 2021
@theopnv theopnv mentioned this pull request Jul 26, 2021
theopnv pushed a commit that referenced this pull request Jul 26, 2021
@theopnv theopnv mentioned this pull request Jul 26, 2021
theopnv pushed a commit that referenced this pull request Jul 26, 2021
@theopnv theopnv mentioned this pull request Jul 26, 2021
theopnv pushed a commit that referenced this pull request Jul 28, 2021
* Backport #5198

* Backport #5186

* Remove dependency on pre-pack step for templates
theopnv pushed a commit that referenced this pull request Jul 28, 2021
* Backport #5198

* Backport #5186

* Delete green revisions file

* Remove green revisions script

* Remove dependency on pre-pack step for templates

* Remove unused fields in editor metafile

* Remove unused fields from shared metafile

Co-authored-by: Liis Kivistik <liis.kivistik@unity3d.com>
theopnv pushed a commit that referenced this pull request Jul 28, 2021
* Backport #5198

* Backport #5186

* Delete green revisions file

* Remove green revisions script

* Update templates pipeline config

* Remove unused fields from metafiles

Co-authored-by: Liis Kivistik <liis.kivistik@unity3d.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants