Fix white flash when changing upsampling to before post process. #5195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancescoC-unity
requested review from
anisunity,
remi-chapelain and
sebastienlagarde
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
sebastienlagarde
approved these changes
Jul 22, 2021
anisunity
approved these changes
Jul 22, 2021
kecho
approved these changes
Jul 22, 2021
remi-chapelain
approved these changes
Jul 26, 2021
sebastienlagarde
deleted the
HDRP/fix-exposure-used-when-history-is-reset
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in master this is only a bug for DLSS I suspect, but I need to fix this for TAAU.
The wrong exposure texture was used with the reset history configuration that happens when switching to an upsampler that happens before post processing. I suspect other situations will trigger the same bug, but this is where I noticed it.
@remi-chapelain this fixes the issue you mentioned in the TAAU PR about white flashes, this PR is merged into that branch if you want to check.
Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/HDRP%252Ffix-exposure-used-when-history-is-reset/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2