Skip to content

Fix for bug with normal depth rendering #5208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 17, 2021
Merged

Fix for bug with normal depth rendering #5208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa537da
Fix for bug with normal map
unity-cchu Jul 23, 2021
f165816
Merge branch 'master' into 2d/Fix-for-normal-depth-rendering
unity-cchu Jul 23, 2021
aa1d765
Fixed issue with normal map not clearing depth
unity-cchu Jul 23, 2021
cfebee4
Update CHANGELOG.md
unity-cchu Jul 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.universal/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed an issue where Sprite type Light2Ds were missing a default sprite
- Fixed an issue where ShadowCasters were sometimes being rendered twice in the editor while in playmode.
- Fixed an issue where ShadowCaster2D was generating garbage when running in the editor. [case 1304158](https://issuetracker.unity3d.com/product/unity/issues/guid/1304158/)
- Fixed an issue where the 2D Renderer was not rendering depth and stencil in the normal rendering pass
- Fixed an issue where 2D lighting was incorrectly calculated when using a perspective camera.
- Fixed an issue where objects in motion might jitter when the Pixel Perfect Camera is used. [case 1300474](https://issuetracker.unity3d.com/issues/urp-characters-sprite-repeats-in-the-build-when-using-pixel-perfect-camera-and-2d-renderer)
- Fixed an issue where filtering in the scene view would not properly highlight the filtered objects. case 1324359
Expand Down
4 changes: 2 additions & 2 deletions com.unity.render-pipelines.universal/Runtime/2D/Passes/Utility/RendererLighting.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public static void CreateNormalMapRenderTexture(this IRenderPass2D pass, Renderi
descriptor.graphicsFormat = GetRenderTextureFormat();
descriptor.useMipMap = false;
descriptor.autoGenerateMips = false;
descriptor.depthBufferBits = 0;
descriptor.depthBufferBits = pass.rendererData.useDepthStencilBuffer ? 32 : 0;
descriptor.msaaSamples = renderingData.cameraData.cameraTargetDescriptor.msaaSamples;
descriptor.dimension = TextureDimension.Tex2D;

Expand Down Expand Up @@ -510,7 +510,7 @@ public static void RenderNormals(this IRenderPass2D pass, ScriptableRenderContex
else
cmd.SetRenderTarget(pass.rendererData.normalsRenderTarget.Identifier(), RenderBufferLoadAction.DontCare, storeAction);

cmd.ClearRenderTarget(false, true, k_NormalClearColor);
cmd.ClearRenderTarget(pass.rendererData.useDepthStencilBuffer, true, k_NormalClearColor);

context.ExecuteCommandBuffer(cmd);
cmd.Clear();
Expand Down