Skip to content

Conversation

unity-cchu
Copy link
Contributor

@unity-cchu unity-cchu commented Jul 23, 2021

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.

Purpose of this PR

This fixes issues where normal maps had no depth/stencil when specified by the 2D Renderer settings.

https://fogbugz.unity3d.com/f/cases/1259874/

https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/2d%252FFix-for-normal-depth-rendering/.yamato%252Fall-urp_2d.yml%2523PR_URP_2D_trunk/7866312/job

@unity-cchu unity-cchu requested a review from a team as a code owner July 23, 2021 09:14
@unity-cchu unity-cchu marked this pull request as draft July 23, 2021 09:14
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@unity-cchu unity-cchu marked this pull request as ready for review July 23, 2021 09:47
@unity-cchu unity-cchu requested review from a team as code owners July 28, 2021 05:50
@phi-lira phi-lira merged commit 76c2bbe into master Aug 17, 2021
@phi-lira phi-lira deleted the 2d/Fix-for-normal-depth-rendering branch August 17, 2021 11:33
kennytann added a commit that referenced this pull request Aug 19, 2021
* Fix for bug with normal map

* Fixed issue with normal map not clearing depth

* Update CHANGELOG.md
# Conflicts:
#	com.unity.render-pipelines.universal/CHANGELOG.md
#	com.unity.render-pipelines.universal/Runtime/2D/Passes/Utility/RendererLighting.cs
kennytann added a commit that referenced this pull request Sep 16, 2021
* Fix for bug with normal map

* Fixed issue with normal map not clearing depth

* Update CHANGELOG.md
# Conflicts:
#	com.unity.render-pipelines.universal/CHANGELOG.md
#	com.unity.render-pipelines.universal/Runtime/2D/Passes/Utility/RendererLighting.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants