Skip to content

Universal/doc 3444 urp shaderui screenshots #5328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2021
Merged

Universal/doc 3444 urp shaderui screenshots #5328

merged 1 commit into from
Aug 19, 2021

Conversation

jpriyas
Copy link
Contributor

@jpriyas jpriyas commented Aug 10, 2021 •
edited
Loading

Purpose of this PR

This PR fixes outdated shader screenshots + adds description for Specular Highlights, where applicable.

Notes to the reviewer

This should be merged into URP 7.x.x/release.

@jpriyas jpriyas added the Docs label Aug 10, 2021
@jpriyas jpriyas requested a review from a team as a code owner August 10, 2021 18:35
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@jpriyas jpriyas changed the base branch from master to 7.x.x/release August 10, 2021 18:50
@jpriyas jpriyas requested review from a team as code owners August 10, 2021 18:50
@theopnv theopnv removed the request for review from a team August 12, 2021 07:40
phi-lira
phi-lira approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@phi-lira phi-lira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's the original PR to master?

@oleks-k oleks-k self-requested a review August 19, 2021 08:28
oleks-k
oleks-k approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@oleks-k oleks-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@phi-lira phi-lira merged commit 15252a4 into 7.x.x/release Aug 19, 2021
@phi-lira phi-lira deleted the universal/doc-3444-urp-shaderui-screenshots branch August 19, 2021 09:19
@jpriyas
Copy link
Contributor Author

jpriyas commented Aug 19, 2021

Where's the original PR to master?

The original PR to Master is #5322. However, the current one (5328) has slight differences due to variations in the UI for 7.x.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oleks-k oleks-k oleks-k approved these changes

+2 more reviewers

@phi-lira phi-lira phi-lira approved these changes

@erikabar erikabar erikabar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Docs universal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jpriyas @phi-lira @erikabar @oleks-k