Skip to content

Doc 3004 #5322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 17, 2021
Merged

Doc 3004 #5322

merged 4 commits into from
Aug 17, 2021

Conversation

jpriyas
Copy link
Contributor

@jpriyas jpriyas commented Aug 9, 2021 •
edited
Loading

Purpose of this PR

This PR fixes most of the shader UI screenshots to replace "Lightweight Render Pipeline" with "Universal Render Pipeline" and "Priority" with "Sorting Priority". It also adds description for Specular Highlights in places it's missing.

@jpriyas jpriyas requested review from a team as code owners August 9, 2021 21:53
@github-actions
Copy link

github-actions bot commented Aug 9, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

github-actions bot commented Aug 9, 2021

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

github-actions[bot]
github-actions bot reviewed Aug 9, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Unity SRP repo!
Please make sure to fill out the PR template as best you can to give reviewers as much information as possible.
If you have any questions (and you are a Unity employee) go to "#devs-renderpipe"

@jpriyas jpriyas merged commit dac8d4c into master Aug 17, 2021
@jpriyas jpriyas deleted the DOC-3004 branch August 17, 2021 08:48
jpriyas added a commit that referenced this pull request Aug 17, 2021
@jpriyas
Doc 3004 (#5322)
2c51d48 
* tweaks to Lit.png

* Tweaks to address screenshot changes

* Update particles-simple-lit-shader.md

Fixed a typo

* Update particles-unlit-shader.md

Fixed a typo
@jpriyas jpriyas mentioned this pull request Aug 17, 2021
Closed
jpriyas added a commit that referenced this pull request Aug 18, 2021
@jpriyas
Doc 3004 (#5322)
e1165c8 
* tweaks to Lit.png

* Tweaks to address screenshot changes

* Update particles-simple-lit-shader.md

Fixed a typo

* Update particles-unlit-shader.md

Fixed a typo
jpriyas added a commit that referenced this pull request Aug 18, 2021
@jpriyas
Doc 3004 (#5322)
44a346c 
* tweaks to Lit.png

* Tweaks to address screenshot changes

* Update particles-simple-lit-shader.md

Fixed a typo

* Update particles-unlit-shader.md

Fixed a typo
This was referenced Aug 18, 2021
Merged
Merged
jpriyas added a commit that referenced this pull request Aug 23, 2021
@jpriyas
Doc 3004 (#5322) (#5392)
32f0600 
* tweaks to Lit.png

* Tweaks to address screenshot changes

* Update particles-simple-lit-shader.md

Fixed a typo

* Update particles-unlit-shader.md

Fixed a typo
jpriyas added a commit that referenced this pull request Sep 7, 2021
@jpriyas
bacporting #5322
2cd47ae
@jpriyas jpriyas mentioned this pull request Sep 7, 2021
Merged
oleks-k pushed a commit that referenced this pull request Sep 10, 2021
@jpriyas
bacporting #5322 (#5559)
45e33bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

+1 more reviewer

@erikabar erikabar erikabar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported-10.x backported-2021.1 Docs universal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpriyas @erikabar