Skip to content

Universal/backport/doc 3004 shader screenshots #5366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Universal/backport/doc 3004 shader screenshots #5366

wants to merge 2 commits into from

Conversation

jpriyas
Copy link
Contributor

@jpriyas jpriyas commented Aug 17, 2021

This PR backports the changes made in Doc 3004 (#5322)

@jpriyas
Doc 3004 (#5322)
2c51d48 
* tweaks to Lit.png

* Tweaks to address screenshot changes

* Update particles-simple-lit-shader.md

Fixed a typo

* Update particles-unlit-shader.md

Fixed a typo
@jpriyas jpriyas requested a review from a team as a code owner August 17, 2021 13:19
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

Shader Graph
/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_2021.2
Depending on your PR, you may also want
/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_2021.2
/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@jpriyas jpriyas changed the base branch from master to 10.x.x/release August 17, 2021 14:10
@jpriyas jpriyas requested a review from a team as a code owner August 17, 2021 14:10
@jpriyas
Doc 3004 (#5322)
e1165c8 
* tweaks to Lit.png

* Tweaks to address screenshot changes

* Update particles-simple-lit-shader.md

Fixed a typo

* Update particles-unlit-shader.md

Fixed a typo
@theopnv theopnv removed the request for review from a team August 19, 2021 07:04
@jpriyas jpriyas closed this Sep 14, 2021
@jpriyas
Copy link
Contributor Author

jpriyas commented Sep 14, 2021

Closing this PR as the v10.x.x merges supersede this.

@jpriyas jpriyas deleted the universal/backport/DOC-3004-shader-screenshots branch September 14, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ellioman ellioman ellioman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

universal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jpriyas @ellioman @sebastienlagarde