Skip to content

Conversation

kaychang-unity
Copy link
Contributor

Purpose of this PR

Fix for https://fogbugz.unity3d.com/f/cases/1347645/.
Terrain heightmap geometry internally use custom instancing code, but unity_RenderingLayer should be uniform to the whole terrain instance (no instancing).


Testing status

Fixed repro project in FB case.


Comments to reviewers

Notes for the reviewers you have assigned.

Terrain heightmap geometry internally use custom instancing code, but unity_RenderingLayer should be uniform to the whole terrain instance (no instancing).
@kaychang-unity kaychang-unity requested review from a team as code owners August 17, 2021 21:00
@kaychang-unity kaychang-unity self-assigned this Aug 17, 2021
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

Copy link
Contributor

@erikabar erikabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Developer already tested with repro project, approving without additional testing

@kaychang-unity kaychang-unity merged commit b733a81 into master Aug 26, 2021
@kaychang-unity kaychang-unity deleted the universal/fb1347645-terrain-light-layers-fix branch August 26, 2021 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants