Skip to content

Conversation

sarah-welton
Copy link
Contributor

Please read the Contributing guide before making a PR.


Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?

The ToC now has a section under Input for Lighting nodes, which correctly contains the Ambient, Reflection Probe, and Baked GI nodes' documentation.

Comments for reviewers

I accidentally dragged-and-dropped another commit that has no changes in it on the branch for this PR. Ignore 4c1a039 - it was already backported and corrected on this branch.

…#5386)

File for Triangle-Wave-Node should now be found in the documentation.
The ToC now has a section under Input for Lighting nodes, which correctly contains the Ambient, Reflection Probe, and Baked GI nodes' documentation
@sarah-welton sarah-welton requested a review from a team as a code owner August 18, 2021 21:00
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

Copy link
Contributor

@jessebarker jessebarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarah-welton sarah-welton merged commit 48da6f5 into 10.x.x/release Aug 19, 2021
@sarah-welton sarah-welton deleted the 10.x.x-backport-sg-doc-fix-1350650 branch August 19, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants