Skip to content

[2021.1 Backport] Fix for normal depth rendering (Cases 1259874 and 1199213) #5400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2021
Merged

[2021.1 Backport] Fix for normal depth rendering (Cases 1259874 and 1199213) #5400

merged 1 commit into from
Sep 16, 2021

Conversation

kennytann
Copy link
Contributor

@kennytann kennytann commented Aug 19, 2021 •
edited
Loading

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?

Backport fix for https://fogbugz.unity3d.com/f/cases/1259874/ and https://fogbugz.unity3d.com/f/cases/1199213/

Testing status

Describe what manual/automated tests were performed for this PR
Fix and test outlined #5208

Comments to reviewers

Notes for the reviewers you have assigned.

@kennytann
Fix for bug with normal depth rendering (#5208)
4dce13b 
* Fix for bug with normal map

* Fixed issue with normal map not clearing depth

* Update CHANGELOG.md
# Conflicts:
#	com.unity.render-pipelines.universal/CHANGELOG.md
#	com.unity.render-pipelines.universal/Runtime/2D/Passes/Utility/RendererLighting.cs
@kennytann kennytann requested a review from unity-cchu August 19, 2021 07:26
@kennytann kennytann self-assigned this Aug 19, 2021
@kennytann kennytann requested a review from a team as a code owner August 19, 2021 07:26
@kennytann kennytann changed the base branch from master to 2021.1/staging August 19, 2021 07:27
@kennytann kennytann requested review from a team as code owners August 19, 2021 07:27
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

URP
/.yamato%252Fall-urp.yml%2523PR_URP_2021.2

Shader Graph
/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_2021.2
Depending on your PR, you may also want
/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_2021.2
/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@theopnv theopnv removed the request for review from a team August 19, 2021 07:39
@BoonKiangTan
Copy link

Backport verified on branch:

Version: 2021.1.18f1.2928
Revision: 2021.1/staging 98a317ec4707
Built: Sun, 08 Aug 2021 21:43:02 GMT
Package branch: 2021.1/2d/backport-1259874-1199213 (4dce13b)

  • case 1362155: Verified both examples in scene look the same and the right example does respect depth buffer
    Note: Used modified shader to test with 21.1 as original one caused errors
    Unity_9TQAtk0npy

  • case1362157: Verified when 2D point light in scene "Use Normal Map" is enabled, door sprites are visible only in the Sprite Mask
    Unity_uphXoySu2i

@ellioman ellioman changed the title Backport for cases 1259874 and 1199213 fix for normal depth rendering [2021.1 Backport] Fix for normal depth rendering (Cases 1259874 and 1199213) Sep 16, 2021
@kennytann kennytann merged commit 1a62299 into 2021.1/staging Sep 16, 2021
@kennytann kennytann deleted the 2021.1/2d/backport-1259874-1199213 branch September 16, 2021 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@unity-cchu unity-cchu unity-cchu approved these changes

@BoonKiangTan BoonKiangTan BoonKiangTan approved these changes

@ernestasKupciunas ernestasKupciunas Awaiting requested review from ernestasKupciunas

+1 more reviewer

@ellioman ellioman ellioman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kennytann kennytann

Labels

2d universal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kennytann @BoonKiangTan @ellioman @unity-cchu