[VFX] Unexpected public API #5425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class has been recently introduced by #4601
ludovic-theobald
approved these changes
Aug 24, 2021
There was a problem hiding this comment.
Hi Paul, thanks for this PR, I also did these changes in that PR, but it's cleaner if it is a PR on its own :)
| public static class VFXHDRPSettingsUtility | ||
| static class VFXHDRPSettingsUtility | ||
| { | ||
| public static void RefreshVfxErrorsIfNeeded(ref bool needRefreshVfxErrors) |
There was a problem hiding this comment.
Do we also need to set RefreshVfxErrorsIfNeeded() to internal or changing the parent class in enough ?
There was a problem hiding this comment.
No, otherwise, this function won't be accessible by any user code, we have :
internal class VFXHDRPSettingsUtility
{
public... //reachable in HDRP
}
ludovic-theobald
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix unexpected public API for VFXHDRPSettingsUtility introduced at #4601
Testing status
Only tested if it compiles locally.
Yamato ⏳
Comments to reviewers
See also this conversation