Skip to content

[VFX] Unexpected public API #5425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2021
Merged

[VFX] Unexpected public API #5425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion com.unity.render-pipelines.high-definition/Editor/VFXGraph/Utility/VFXHDRPSettingsUtility.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace UnityEditor.VFX.HDRP
{
public static class VFXHDRPSettingsUtility
static class VFXHDRPSettingsUtility
{
public static void RefreshVfxErrorsIfNeeded(ref bool needRefreshVfxErrors)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to set RefreshVfxErrorsIfNeeded() to internal or changing the parent class in enough ?

Copy link
Contributor Author

@PaulDemeulenaere PaulDemeulenaere Aug 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, otherwise, this function won't be accessible by any user code, we have :

internal class VFXHDRPSettingsUtility
{
 public... //reachable in HDRP
}

{
Expand Down