-
Notifications
You must be signed in to change notification settings - Fork 855
Internal Inspector Bugfixes #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove references to trunk or master * update metafile
# Conflicts: # com.unity.shadergraph/Editor/Data/Graphs/GraphData.cs
# Conflicts: # com.unity.shadergraph/Editor/Data/Graphs/GraphData.cs # com.unity.shadergraph/Editor/Drawing/Views/GraphEditorView.cs
…anup [skip ci] # Conflicts: # com.unity.shadergraph/Editor/Drawing/Inspector/PropertyDrawers/ShaderGUIOverridePropertyDrawer.cs # com.unity.shadergraph/Editor/Drawing/Views/GraphEditorView.cs # com.unity.shadergraph/Editor/Drawing/Views/MaterialNodeView.cs
…tor after deletion # Conflicts: # com.unity.shadergraph/Editor/Drawing/Inspector/PropertyDrawers/ShaderInputPropertyDrawer.cs
# Conflicts: # com.unity.shadergraph/Editor/Data/Nodes/AbstractMaterialNode.cs # com.unity.shadergraph/Editor/Drawing/Views/GraphEditorView.cs
…ctor # Conflicts: # com.unity.shadergraph/Editor/Drawing/Views/GraphEditorView.cs # com.unity.shadergraph/Editor/Drawing/Views/MaterialNodeView.cs # com.unity.shadergraph/Editor/Drawing/Views/PropertyNodeView.cs
…or and reordering targets
com.unity.render-pipelines.core: 9.0.0-preview.29 com.unity.render-pipelines.high-definition-config: 9.0.0-preview.31 com.unity.render-pipelines.high-definition: 9.0.0-preview.29 com.unity.render-pipelines.lightweight: 9.0.0-preview.30 com.unity.render-pipelines.universal: 9.0.0-preview.30 com.unity.shadergraph: 9.0.0-preview.30 com.unity.visualeffectgraph: 9.0.0-preview.29
com.unity.render-pipelines.core: 9.0.0-preview.30 com.unity.render-pipelines.high-definition-config: 9.0.0-preview.32 com.unity.render-pipelines.high-definition: 9.0.0-preview.30 com.unity.render-pipelines.lightweight: 9.0.0-preview.31 com.unity.render-pipelines.universal: 9.0.0-preview.31 com.unity.shadergraph: 9.0.0-preview.31 com.unity.visualeffectgraph: 9.0.0-preview.30
* update dependency of promotion job * add publish as a dependency
* [9.x.x] Merge Hdrp/staging [Skip CI] (#544) * Delete 4052_TAA.png.orig * [10.x.x] Update threashold of HDRP DXR 802 deferred SSS test * Update 801_SubSurfaceScatteringDeferred.unity * update vulkan reference screenshots 4052 / 9301 * Update upm-ci-hdrp.yml
# Conflicts: # .yamato/upm-ci-abv.yml # .yamato/upm-ci-hdrp.yml # .yamato/upm-ci-hdrp_dxr.yml # .yamato/upm-ci-hdrp_hybrid.yml # .yamato/upm-ci-hdrp_standalone.yml # .yamato/upm-ci-packages.yml # .yamato/upm-ci-shadergraph.yml # .yamato/upm-ci-shadergraph_stereo.yml # .yamato/upm-ci-templates.yml # .yamato/upm-ci-universal.yml # .yamato/upm-ci-universal_hybrid.yml # .yamato/upm-ci-universal_stereo.yml # .yamato/upm-ci-vfx_lwrp.yml # .yamato/upm-ci-vfxmain.yml # .yamato/z_editor.yml # com.unity.render-pipelines.core/package.json # com.unity.render-pipelines.high-definition-config/package.json # com.unity.render-pipelines.high-definition/package.json # com.unity.render-pipelines.lightweight/package.json # com.unity.render-pipelines.universal/package.json # com.unity.shadergraph/package.json # com.unity.visualeffectgraph/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR includes fixes for:
Testing status
Manual Tests
Comments to reviewers
If this is an issue I can add the code for them back in but the changes are fairly straightforward (i.e. the removal of the interface reference from all master nodes) and the functionality has been preserved. Eventually this code will be removed when master stacks lands regardless so the IHasSettings interface would need to be removed at some point.