Skip to content

Updating DLSS documentation #5433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2021
Merged

Updating DLSS documentation #5433

merged 2 commits into from
Sep 2, 2021

Conversation

kecho
Copy link
Contributor

@kecho kecho commented Aug 25, 2021 •
edited
Loading

Purpose of this PR

Updating docs for DLSS.
Specifying minimum platforms, and minimum compatible cards.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the HDRP label Aug 25, 2021
@sebastienlagarde sebastienlagarde marked this pull request as ready for review August 25, 2021 14:22
Vic-Cooper
Vic-Cooper requested changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@Vic-Cooper Vic-Cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check if we can mention the name of a specific NVidia GPU in our docs.

...nity.render-pipelines.high-definition/Documentation~/deep-learning-super-sampling-in-hdrp.md
To build your project for **Windows**, use **x86_64** architecture (Win64).

DLSS compatibility also depends on the graphics card utilized. It only works on an NVIDIA GPU greater or equal to series GeForce RTX 2060.

Copy link
Contributor

@Vic-Cooper Vic-Cooper Aug 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HDRP supports DLSS on the following platforms:

  • DirectX 11 on Windows 64 bit
  • DirectX 12 on Windows 64 bit
  • Vulkan on Windows 64 bit

HDRP does not support DLSS for Metal, Linux, Windows using x86 architecture (Win32), or any other platform.

To build your project for Windows, use x86_64 architecture (Win64).

For information about the hardware requirements of DLSS, see NVIDIA'S DLSS requirements.

Vic-Cooper
Vic-Cooper requested changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@Vic-Cooper Vic-Cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed header for clarity.

...nity.render-pipelines.high-definition/Documentation~/deep-learning-super-sampling-in-hdrp.md

This section includes HDRP-specific requirements and compatibility information for DLSS. For information about the general requirements and compatibility of DLSS, see [Deep learning super sampling](https://docs.unity3d.com/2021.2/Documentation/Manual/deep-learning-super-sampling.html).

### Platforms
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supported platforms

@Vic-Cooper
Copy link
Contributor

wrt mentioning GPUs, it's better to link to NVIDIA's docs directly, I'll edit my suggestion accordingly.

Vic-Cooper
Vic-Cooper requested changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@Vic-Cooper Vic-Cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added link to NVIDIA'S DLSS requirements page.

@kecho kecho force-pushed the HDRP/DLSSDocumentationUpdate branch from ff40c99 to b0fd443 Compare September 2, 2021 13:26
@kecho kecho requested a review from Vic-Cooper September 2, 2021 13:26
@kecho
Copy link
Contributor Author

kecho commented Sep 2, 2021

@Vic-Cooper thank you for the suggestions. They should be now merged.

@sebastienlagarde
Copy link
Contributor

Correction adresse, merging.

@sebastienlagarde sebastienlagarde merged commit 09b70e7 into master Sep 2, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/DLSSDocumentationUpdate branch September 2, 2021 15:39
sebastienlagarde pushed a commit that referenced this pull request Sep 3, 2021
@kecho @sebastienlagarde
Updating DLSS documentation (#5433)
c2e3726 
* Updating DLSS documentation

* Updating grammar reviewed by technical writter Vic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vic-Cooper Vic-Cooper Awaiting requested review from Vic-Cooper

1 more reviewer

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported-2021.2 HDRP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kecho @Vic-Cooper @sebastienlagarde