Skip to content

Conversation

ellioman
Copy link
Contributor

@ellioman ellioman commented Aug 25, 2021

Purpose of this PR

In #2146 I introduced a regression, causing the main color to change in materials using Unlit and Particles Unlit shaders.
This affected several of our CI tests.

The fix is to add the [Gamma] tag to those properties.

Yamato

https://unity-ci.cds.internal.unity3d.com/job/8350051

@ellioman ellioman requested a review from Verasl August 25, 2021 14:19
@ellioman ellioman requested review from a team as code owners August 25, 2021 14:19
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

Copy link
Contributor

@Verasl Verasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ellioman ellioman closed this Aug 26, 2021
@ellioman
Copy link
Contributor Author

Closed as this PR and will revert the original changes as well.
This requires a bit more work to find a better solution which we've noted down.

@ellioman ellioman deleted the universal/unlit-hdr-fix branch August 26, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants