[HDRP] Adding information about SSGI and Emissive incompatibility in documentation and override #5468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
iM0ve
approved these changes
Aug 31, 2021
sebastienlagarde
approved these changes
Aug 31, 2021
remi-chapelain
changed the title
remi-chapelain
requested review from
emilybrown1,
iM0ve and
sebastienlagarde
emilybrown1
suggested changes
Sep 2, 2021
com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md
Outdated
Show resolved
Hide resolved
com.unity.render-pipelines.high-definition/Documentation~/Override-Screen-Space-GI.md
Outdated
Show resolved
Hide resolved
Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com>
emilybrown1
approved these changes
Sep 2, 2021
sebastienlagarde
approved these changes
Sep 2, 2021
sebastienlagarde
deleted the
HDRP/adding-ssgi-emissive-incompatibility-info
branch
sebastienlagarde
pushed a commit
that referenced
this pull request
Sep 3, 2021
…documentation and override (#5468) * adding bit of info * Adding links * fixing typo * Helpbox in SSGI override * Apply suggestions from code review Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR is needed because lots of users are thinking this is a bug and or asking this question (why I lose emissive when I enable SSGI).
Now we can just point to this documentation bit when the question is popping up.
Also, an HelpBox have been added to the SSGI override to give this information in editor.
The HeloBox only appears when SSGI is enabled.
Comments to reviewers
If someone have a better wording or want to correct things, please do it.