Skip to content

[URP][UI-UX] Removed the cookie foldout and moved into emission #5525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2021
Merged

[URP][UI-UX] Removed the cookie foldout and moved into emission #5525

merged 1 commit into from
Sep 14, 2021

Conversation

martint-unity
Copy link
Contributor

@martint-unity martint-unity commented Sep 3, 2021 •
edited
Loading

Purpose of this PR

Removing the cookielight foldout in URP and move the cookie property into emission foldout group

image

Testing status

Check that the cookie property still works and are now under the emission foldout in the inspector

@martint-unity martint-unity requested review from a team, eh-unity and ellioman September 3, 2021 12:54
@martint-unity martint-unity requested a review from a team as a code owner September 3, 2021 12:54
@github-actions
Copy link

github-actions bot commented Sep 3, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@martint-unity martint-unity changed the title Removed the cookie foldout and moved into emission [URP][UI-UX] Removed the cookie foldout and moved into emission Sep 3, 2021
eh-unity
eh-unity approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@eh-unity eh-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

@aleksandrasdzikia aleksandrasdzikia requested review from aleksandrasdzikia and removed request for a team September 7, 2021 16:11
@martint-unity martint-unity merged commit 2053942 into master Sep 14, 2021
@martint-unity martint-unity deleted the universal/ui-ux-fix-for-cookie-foldout branch September 14, 2021 11:52
@arttu-peltonen arttu-peltonen mentioned this pull request Oct 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aleksandrasdzikia aleksandrasdzikia aleksandrasdzikia approved these changes

@eh-unity eh-unity eh-unity approved these changes

+1 more reviewer

@ellioman ellioman ellioman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

universal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@martint-unity @ellioman @aleksandrasdzikia @eh-unity