Skip to content

Conversation

arttu-peltonen
Copy link
Contributor

Looks like the duplicate cookie field this was accidentally re-added after @martint-unity had removed it, probably a merge artifact. The Light Cookie field is now part of the Emission group.

Before this fix:
image

After this fix:
image

@arttu-peltonen arttu-peltonen self-assigned this Oct 4, 2021
@arttu-peltonen arttu-peltonen marked this pull request as ready for review October 4, 2021 12:18
@arttu-peltonen arttu-peltonen requested review from a team as code owners October 4, 2021 12:18
@github-actions
Copy link

github-actions bot commented Oct 4, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link
Contributor

@martint-unity martint-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arttu-peltonen arttu-peltonen merged commit 68bf3dd into master Oct 5, 2021
@arttu-peltonen arttu-peltonen deleted the bugfix/duplicate-presetinspector-cookie-field branch October 5, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants