Skip to content

Conversation

Nzollner
Copy link
Contributor

@Nzollner Nzollner commented Sep 3, 2021

Purpose of this PR

This PR is needed in order to use changed normals in the shadow caster if they are updated in the fragment shader. Otherwise will the normal bias break the shadows.


Testing status

I have tested the fix with the project given in the bug and tested if the universal graphics tests worked locally.


Comments to reviewers

Notes for the reviewers you have assigned.

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link
Contributor

@pbbastian pbbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phi-lira phi-lira changed the base branch from master to universal/staging October 6, 2021 14:40
@phi-lira phi-lira changed the base branch from universal/staging to master October 6, 2021 14:41
@phi-lira phi-lira changed the base branch from master to universal/staging October 6, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants