-
Notifications
You must be signed in to change notification settings - Fork 855
ShadowCaster now using varyings normalWS for shader graph #5527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. URP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… into universal/bugfix/1349095
… into universal/bugfix/1349095
Purpose of this PR
This PR is needed in order to use changed normals in the shadow caster if they are updated in the fragment shader. Otherwise will the normal bias break the shadows.
Testing status
I have tested the fix with the project given in the bug and tested if the universal graphics tests worked locally.
Comments to reviewers
Notes for the reviewers you have assigned.