Skip to content

Conversation

Nzollner
Copy link
Contributor

@Nzollner Nzollner commented Oct 8, 2021

Purpose of this PR

This is a backport for this PR. It ensures the shadow caster receives the newest update of the normals such that the shadow normal bias is correct.


Testing status

I have tested the fix with the project given in the bug and tested if the universal graphics tests worked locally.

@github-actions
Copy link

github-actions bot commented Oct 8, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

github-actions bot commented Oct 8, 2021

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@Nzollner Nzollner merged commit 25a4235 into 2021.2/staging Oct 18, 2021
@Nzollner Nzollner deleted the 2021.2/universal/backport/1371255 branch October 18, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants