Skip to content

Conversation

anisunity
Copy link
Contributor

After getting complains froms users about the quality of the shadows, I tried improve the result a bit without any major changes.

  • Added an option for the ultra 1024x1024 mode for the volumetric cloud shadows and a filtering pass to reduce the aliasing artifacts of the clouds shadow.
  • Changed the number of steps to evaluate the shadow from 9 to 16.
    image

Testing status
The result is improved in previously existing shadow resolutions
The result is improved with the new resolution
Some tests will need screenshot updates.

@anisunity anisunity added the HDRP label Sep 7, 2021
@anisunity anisunity self-assigned this Sep 7, 2021
@github-actions
Copy link

github-actions bot commented Sep 7, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link
Contributor

@TomasKiniulis TomasKiniulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming Reference Images are updated and CI is passing looks good. The smaller clouds actually get shadows now and the shadows themselves look much smoother even on smaller resolutions.

Attaching test results:
Small clouds master
image (56)
Small clouds PR
image (55)

Larger scale clouds master 512 resolution
image (57)
Larger scale clouds PR 512 resolution
image (58)
Larger scale clouds PR 1024 resolution
image (59)

Copy link
Contributor

@pierre-unity pierre-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working well, much smoother and ability to push resolution slightly

… shadows and a filtering pass to reduce the aliasing artifacts of the clouds shadow.

Changed the number of steps to evaluate the shadow from 9 to 16.
@anisunity anisunity force-pushed the HDRP/improve-clouds-shadow branch from a34eb67 to e18e49a Compare September 8, 2021 17:13
@anisunity
Copy link
Contributor Author

This PR has been merged in this PR for making screenshot regeneration easier #5546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants