-
Notifications
You must be signed in to change notification settings - Fork 855
Fixed regression in the ambient probe intensity for volumetric clouds. #5546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
0ca0a93
to
8327da6
Compare
This PR now also includes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally
… shadows and a filtering pass to reduce the aliasing artifacts of the clouds shadow. Changed the number of steps to evaluate the shadow from 9 to 16.
Merged #5556 into this PR |
In this PR i've added a fix to this bug https://fogbugz.unity3d.com/f/cases/1364152/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked with Anis on concerns I had, looks all good assuming CI is green.
Updated all screenshots and relaunched yamato |
When adding the code that changes which ambient probe is used. I removed pieces of the code that i thought were optional (spoiler alert, they are not). This adds them back and restores a look that is closer to what we expect.

@pierre-unity is going to update the LUT so I have to wait before updating the screenshots
Testing status
Tested on the samples, looks good now.
This will break a bunch of clouds tests