Skip to content

Conversation

anisunity
Copy link
Contributor

@anisunity anisunity commented Sep 7, 2021

When adding the code that changes which ambient probe is used. I removed pieces of the code that i thought were optional (spoiler alert, they are not). This adds them back and restores a look that is closer to what we expect.
image

@pierre-unity is going to update the LUT so I have to wait before updating the screenshots

Testing status
Tested on the samples, looks good now.
This will break a bunch of clouds tests

@anisunity anisunity self-assigned this Sep 7, 2021
@github-actions
Copy link

github-actions bot commented Sep 7, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@anisunity anisunity force-pushed the HDRP/fix-clouds-probe-regression branch from 0ca0a93 to 8327da6 Compare September 8, 2021 16:43
@anisunity
Copy link
Contributor Author

This PR now also includes:

  • An update of the presets by @pierre-unity
  • A fix for the sun leaking behind the clouds
  • A fix for an artifact appearing when in non local mode and lowest cloud altitude very low.

@anisunity anisunity marked this pull request as ready for review September 8, 2021 16:44
Copy link
Contributor

@pierre-unity pierre-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally

… shadows and a filtering pass to reduce the aliasing artifacts of the clouds shadow.

Changed the number of steps to evaluate the shadow from 9 to 16.
@anisunity
Copy link
Contributor Author

Merged #5556 into this PR

@anisunity
Copy link
Contributor Author

In this PR i've added a fix to this bug https://fogbugz.unity3d.com/f/cases/1364152/

Copy link
Contributor

@TomasKiniulis TomasKiniulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with Anis on concerns I had, looks all good assuming CI is green.

@anisunity
Copy link
Contributor Author

Updated all screenshots and relaunched yamato

@anisunity anisunity merged commit 3b22316 into master Sep 10, 2021
@anisunity anisunity deleted the HDRP/fix-clouds-probe-regression branch September 10, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants