Skip to content

SRP Workflows - Fix invalid cast exception #5561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2021
Merged

SRP Workflows - Fix invalid cast exception #5561

merged 1 commit into from
Sep 8, 2021

Conversation

alex-vazquez
Copy link
Contributor

Purpose of this PR

https://jira.unity3d.com/browse/XPIPELINE-275

Testing status

Check the invalid cast is not longer happening

@alex-vazquez alex-vazquez self-assigned this Sep 8, 2021
@github-actions
Copy link

github-actions bot commented Sep 8, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the HDRP label Sep 8, 2021
TomasKiniulis
TomasKiniulis approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@TomasKiniulis TomasKiniulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Works like a charm

jenniferd-unity
jenniferd-unity approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@jenniferd-unity jenniferd-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put suggestions but otherwise it is good to go for me :)

com.unity.render-pipelines.high-definition/Runtime/Lighting/Reflection/HDProbe.cs
}
else
{
if (!(RenderPipelineManager.currentPipeline is HDRenderPipeline hdrp))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can simplify with HDRenderPipeline.asset != null and/or HDRenderPipeline.currentPlatformRenderPipelineSettings != null ?

@alex-vazquez alex-vazquez marked this pull request as ready for review September 8, 2021 10:32
@alex-vazquez alex-vazquez merged commit 74d95cb into master Sep 8, 2021
@alex-vazquez alex-vazquez deleted the x-pipeline/fix-invalid-cast-exception branch September 8, 2021 11:19
sebastienlagarde pushed a commit that referenced this pull request Sep 12, 2021
@alex-vazquez @sebastienlagarde
Fix invalid cast exception (#5561)
126ecb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@TomasKiniulis TomasKiniulis TomasKiniulis approved these changes

@jenniferd-unity jenniferd-unity jenniferd-unity approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alex-vazquez alex-vazquez

Labels

backported-2021.2 HDRP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alex-vazquez @TomasKiniulis @jenniferd-unity @sebastienlagarde @alex-vazquez-unity3d