Skip to content

SRP Workflows - Fix invalid cast exception #5561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2021
Merged

SRP Workflows - Fix invalid cast exception #5561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed missing API documentation for LTC area light code.
- Fixed diffusion profile breaking after upgrading HDRP (case 1337892).
- Fixed undo on light anchor.
- Fixed invalid cast exception on HDProbe.
- Fixed some depth comparison instabilities with volumetric clouds.
- Fixed AxF debug output in certain configurations (case 1333780).
- Fixed white flash when camera is reset and SSR Accumulation mode is on.
Expand Down
12 changes: 4 additions & 8 deletions com.unity.render-pipelines.high-definition/Runtime/Lighting/Reflection/HDProbe.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,15 +633,11 @@ private Vector3 ComputeCapturePositionWS()

private void QueueSHBaking()
{
var hdrp = (HDRenderPipeline)RenderPipelineManager.currentPipeline;
if (hdrp != null)
{
if (!hdrp.currentPlatformRenderPipelineSettings.supportProbeVolume) return;
}
else
{
if (!(RenderPipelineManager.currentPipeline is HDRenderPipeline hdrp))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can simplify with HDRenderPipeline.asset != null and/or HDRenderPipeline.currentPlatformRenderPipelineSettings != null ?

return;

if (!hdrp.currentPlatformRenderPipelineSettings.supportProbeVolume)
return;
}

Vector3 capturePositionWS = ComputeCapturePositionWS();
if (m_SHRequestID < 0)
Expand Down