Skip to content

Conversation

Nightmask3
Copy link
Contributor

Details:

Backport of this PR for 9.x.x.

Manual Tests:

  • Ran the local ShaderGraph test project and verified all tests are passing
  • Closing and opening the graph to verify serialization of layout and window sizing/positions are preserved
  • Adding/removing/renaming/moving/deleting blackboard properties and keywords along with undo/redo at every stage, verified that no regressions here
  • Changing property/keyword values through the inspector and watching the graph preview update and the shaders recompile, everything seems to be working as expected
  • Selecting graph elements (like nodes and properties from the blackboards) and verifying that the inspector displays what is selected.
  • Selecting various kinds of elements and making sure that whenever they are deselected, the inspector is hidden when nothing remains to display, including when undo/redo changes active selection.
  • When color mode is set to "Precision" and the precision is changed through the graph settings in the inspector, verified that the entire graph colors update to Float/Half if the nodes are set to Inherit.

# Conflicts:
#	com.unity.shadergraph/Editor/Data/Graphs/GraphData.cs
…anup

[skip ci]

# Conflicts:
#	com.unity.shadergraph/Editor/Drawing/Inspector/PropertyDrawers/ShaderGUIOverridePropertyDrawer.cs
#	com.unity.shadergraph/Editor/Drawing/Views/GraphEditorView.cs
#	com.unity.shadergraph/Editor/Drawing/Views/MaterialNodeView.cs

# Conflicts:
#	com.unity.shadergraph/Editor/Drawing/Views/GraphEditorView.cs
…tor after deletion

# Conflicts:
#	com.unity.shadergraph/Editor/Drawing/Inspector/PropertyDrawers/ShaderInputPropertyDrawer.cs
# Conflicts:
#	com.unity.shadergraph/Editor/Data/Nodes/AbstractMaterialNode.cs
#	com.unity.shadergraph/Editor/Drawing/Views/GraphEditorView.cs

# Conflicts:
#	com.unity.shadergraph/Editor/Drawing/Views/MaterialNodeView.cs
# Conflicts:
#	com.unity.shadergraph/Editor/Drawing/Inspector/InspectorView.cs
…ctor

# Conflicts:
#	com.unity.shadergraph/Editor/Drawing/Views/GraphEditorView.cs
#	com.unity.shadergraph/Editor/Drawing/Views/MaterialNodeView.cs
#	com.unity.shadergraph/Editor/Drawing/Views/PropertyNodeView.cs
…or and reordering targets

# Conflicts:
#	com.unity.shadergraph/Editor/Drawing/Inspector/PropertyDrawers/GraphDataPropertyDrawer.cs
#	com.unity.shadergraph/Editor/Drawing/Views/MaterialGraphView.cs
@Nightmask3 Nightmask3 requested review from a user, marctem and sebastienlagarde May 19, 2020 20:54
@Nightmask3 Nightmask3 requested review from a team as code owners May 19, 2020 20:54
@Nightmask3 Nightmask3 requested review from eh-unity and removed request for a team May 19, 2020 20:54
@alindmanUnity alindmanUnity self-assigned this May 19, 2020
@Nightmask3 Nightmask3 mentioned this pull request May 19, 2020
@sebastienlagarde sebastienlagarde deleted the sg/inspector-bugfixes-9.x.x branch September 1, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants