Skip to content

Conversation

ellioman
Copy link
Contributor

@ellioman ellioman commented Sep 9, 2021

Purpose of this PR

Backporting the fix done in #5591.

Testing

What has been tested

  • Tested in the Editor (Mac) with three different cameras and two volumes

Yamato

https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/2021.2%252Fbackports%252Fvolume-update-fix

@ellioman ellioman requested a review from Verasl September 9, 2021 14:11
@ellioman ellioman requested review from a team as code owners September 9, 2021 14:11
@github-actions
Copy link

github-actions bot commented Sep 9, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@ellioman ellioman changed the title [2021.2] Fix for Volume Updates [2021.2 Backport] Fix for Volume Updates Sep 9, 2021
Copy link
Contributor

@Verasl Verasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple back port LGTM

@ellioman
Copy link
Contributor Author

Failures on Yamato not related to this PR.

@ellioman ellioman merged commit a89c825 into 2021.2/staging Sep 13, 2021
@ellioman ellioman deleted the 2021.2/backports/volume-update-fix branch September 13, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants