[2022.1] Fix for Volume Updates #5591
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
In #4242 we introduced a setting to control the updates URP does to the Volume Framework.
There was however an issue when switching between
EveryFrame
andViaScripting
in the URP Asset after moving the camera. The issue is that the camera would use an old stack that had been saved earlier instead of an updated one right before the switch to ViaScripting. The reason for this was that thevolumeStack
is only updated if it was null or when the setting is changed on the camera.The solution is to destroy the
volumeStack
if the Volume Update Setting is set toEveryFrame
. That guarantees that the volumeStack will be created and updated when the switch betweenEveryFrame
andViaScripting
happens. This PR also also makes sure we do not update the stack when switching betweenViaScripting
andUsePipeline
on the camera when the URP Asset is set toViaScripting
.Testing
What has been tested
Yamato
https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/universal%252Fvolume-update-fix