Skip to content

Conversation

ellioman
Copy link
Contributor

@ellioman ellioman commented Sep 9, 2021

Purpose of this PR

Backporting the Volume Update feature done in #4242 and a subsequent fix done in #5591.

Testing

What has been tested

  • Tested in the Editor (Mac) with three different cameras and two volumes

Yamato

https://unity-ci.cds.internal.unity3d.com/job/8632709

@ellioman ellioman requested a review from Verasl September 9, 2021 14:17
@ellioman ellioman requested review from a team as code owners September 9, 2021 14:17
@github-actions github-actions bot added the SRP label Sep 9, 2021
@ellioman ellioman changed the title Backport of #4242 [2021.1 Backport] Control Volume Framework updates + Fix for Volume Updates Sep 9, 2021
Copy link
Contributor

@Verasl Verasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM would be good to have QA to a very quick surface level test

@ellioman
Copy link
Contributor Author

Issues on Yamato are not related to this PR.

@ellioman ellioman merged commit 14c1eed into 2021.1/staging Sep 13, 2021
@ellioman ellioman deleted the 2021.1/backports/volumes-control-updates branch September 13, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants