Skip to content

Conversation

kennytann
Copy link
Contributor

@kennytann kennytann commented Sep 13, 2021

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?

Adds public api for shape path in Light2D which allows users to set their own custom shapes for freeform lights.
Updated docs to reflect the changes.


Testing status

Describe what manual/automated tests were performed for this PR

Open UniversalGraphicsTest_2D project from graphics repo.
Open TestRunner.
Select PlayMode tab.
Run 2 tests "CachedMeshDataIsOverriddenByRuntimeChanges" and "CachedMeshDataIsUpdatedOnChange".
Ensure the tests are successful.


Comments to reviewers

Notes for the reviewers you have assigned.

@kennytann kennytann self-assigned this Sep 13, 2021
@kennytann kennytann requested review from a team as code owners September 13, 2021 02:07
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link

@ernestasKupciunas ernestasKupciunas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving without testing. Good job with the testing coverage!

@BoonKiangTan
Copy link

Fix verified on branch:

Version: 2022.1.0a10.1326
Revision: trunk 48c8cfa2acec
Built: Fri, 17 Sep 2021 07:51:06 GMT
Package branch: 2d/public-api-light2d-shape-path (8543fa5)

  • Verified changed public API "shapeLightFalloffSize" , "SetShapePath" and "falloffIntensity" work as intended
    image

  • Verified added "CachedMeshDataIsOverriddenByRuntimeChanges" and "CachedMeshDataIsUpdatedOnChange" tests pass
    image

  • Verified summary API description displays correctly
    image

@kennytann kennytann merged commit 6f87bf8 into master Sep 30, 2021
@kennytann kennytann deleted the 2d/public-api-light2d-shape-path branch September 30, 2021 10:04
unity-emilk pushed a commit that referenced this pull request Nov 7, 2022
Update light2d properties and docs

Backported the following PRs
#5618
#5926
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants