-
Notifications
You must be signed in to change notification settings - Fork 855
Expose Light2D properties for scripts - Shape properties, falloff intensity #5618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. URP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
# Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving without testing. Good job with the testing coverage!
Fix verified on branch: Version: 2022.1.0a10.1326 |
Please read the Contributing guide before making a PR.
Checklist for PR maker
CHANGELOG.md
file.Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Adds public api for shape path in Light2D which allows users to set their own custom shapes for freeform lights.
Updated docs to reflect the changes.
Testing status
Describe what manual/automated tests were performed for this PR
Open UniversalGraphicsTest_2D project from graphics repo.
Open TestRunner.
Select PlayMode tab.
Run 2 tests "CachedMeshDataIsOverriddenByRuntimeChanges" and "CachedMeshDataIsUpdatedOnChange".
Ensure the tests are successful.
Comments to reviewers
Notes for the reviewers you have assigned.