-
Notifications
You must be signed in to change notification settings - Fork 855
Update light2d properties and expose settor for sprite light #5926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. URP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
It appears that you made a non-draft PR! |
API verified on branch: 2022.1.0a12.1604 |
#5926 commit 2a7950f Author: Kenny Tan <kenny.tan@unity3d.com> Date: Tue Oct 12 16:51:52 2021 +0800 Remove check for m_DeprecatedPointLightCookieSprite commit 25cf985 Author: Kenny Tan <kenny.tan@unity3d.com> Date: Wed Oct 6 11:55:05 2021 +0800 Update light2d properties and expose settor for sprite light
#5926 commit 2a7950f Author: Kenny Tan <kenny.tan@unity3d.com> Date: Tue Oct 12 16:51:52 2021 +0800 Remove check for m_DeprecatedPointLightCookieSprite commit 25cf985 Author: Kenny Tan <kenny.tan@unity3d.com> Date: Wed Oct 6 11:55:05 2021 +0800 Update light2d properties and expose settor for sprite light
Merged on staging branch #6085 |
Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Users are able to set/change sprite mesh in sprite lights using scripting api
https://forum.unity.com/threads/setting-lightcookiesprite-for-light2d-experimental.1117513/#post-7209010
Testing status
Describe what manual/automated tests were performed for this PR
Add a Light2D of Sprite type to the scene.
Create a new script with the following code to test.
Comments to reviewers
Notes for the reviewers you have assigned.